fix(cli): use bun in command hints#632
Merged
jrusso1020 merged 1 commit intoheygen-com:mainfrom May 7, 2026
Merged
Conversation
jrusso1020
approved these changes
May 6, 2026
Collaborator
jrusso1020
left a comment
There was a problem hiding this comment.
Verdict
Approve. Trivial, correct alignment of user-facing CLI hints with the documented bun-based workflow (CLAUDE.md:23 and AGENTS.md:65 both call out bun as the workspace package manager and explicitly say "NOT pnpm"). Each replacement is verified against the corresponding package.json script.
Verified:
packages/studio/package.jsondefines"dev": "vite"→spawn("bun", ["run", "dev"])is equivalent to the previouspnpm exec vite.packages/player/package.jsondefines"build": "tsup"→bun run --cwd packages/player buildbuilds the player as expected.- Root
package.jsondefines"build"(orchestrates all packages) →bun run buildis the correct root-level build. - Author's stated scope is right: pnpm references in
installerDetection.ts/autoUpdate.tsare correctly left alone — those detect end-user global installs and pnpm-installed users still need thepnpm add -gupgrade hint.
Key Concerns
(none)
Test Coverage
No test changes needed — these are message-string and command-name updates. The studioServer HTML snippet and the play/preview error paths are infrequent fallback branches; existing tests don't (and don't need to) snapshot the literal text.
Nits / Future
packages/cli/src/commands/play.ts:28,36andpackages/cli/src/server/studioServer.ts:412—bun run buildis ambiguous about the working directory (it's a root-level script). The originalpnpm buildhad the same ambiguity, so this isn't a regression, but contributor-facing hints could be made explicit, e.g.bun run buildfrom the monorepo root orbun run --cwd <repo-root> build. Pure copy.packages/cli/src/commands/preview.ts:262—runLocalStudioModestill spawnsnpx vite, which is intentional (this path runs against a user-installed@hyperframes/studio, not the monorepo) and consistent with using a universally available launcher. Just flagging that thepnpm→buncleanup is correctly not extended here; no action needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hyperframes previewruns from the monorepo source path.Why
I noticed a few user-facing CLI paths still referenced pnpm while checking the repo setup. CONTRIBUTING.md and AGENTS.md describe bun as the workspace package manager, so this keeps those small hints aligned with the documented development flow.
Validation
bunx oxfmt --check packages/cli/src/commands/play.ts packages/cli/src/commands/preview.ts packages/cli/src/server/studioServer.tsbunx oxlint packages/cli/src/commands/play.ts packages/cli/src/commands/preview.ts packages/cli/src/server/studioServer.tsbun run --filter @hyperframes/cli typecheckbun run --filter @hyperframes/cli test -- src/server/studioServer.test.ts